server/api/registry/license-change/[...pkg].get.ts (1)

41-49: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Validate currentVersionIndex before array access.

The currentVersionIndex can be -1 in two scenarios: (1) when version === 'latest' and the versions array is empty, or (2) when findIndex fails to locate the requested version. Accessing versions[currentVersionIndex] on line 49 with a negative index violates type-safety. As per coding guidelines, always check when accessing an array value by index.

🛡️ Proposed fix to validate currentVersionIndex

 const currentVersionIndex =
   version === 'latest' ? versions.length - 1 : versions.findIndex(v => v.version === version)

+if (currentVersionIndex < 0) {
+  throw createError({
+    statusCode: 404,
+    statusMessage: 'Version not found',
+  })
+}
+
 const previousVersionIndex = currentVersionIndex - 1
 if (previousVersionIndex < 0) {
   return { change }
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@server/api/registry/license-change/`[...pkg].get.ts around lines 41 - 49,
currentVersionIndex can be -1 (empty versions or findIndex miss), so before
accessing versions[currentVersionIndex] in the assignment to currentLicense,
validate currentVersionIndex is within [0, versions.length-1]; if it's -1 or out
of range, set currentLicense to 'UNKNOWN' (or the existing fallback) and
proceed—update the logic around the currentVersionIndex calculation and the
currentLicense assignment to guard against negative indices and avoid unsafe
array access.